Skip to content

[DNM] Add support for shot-wise output for IonQ jobs #3535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[DNM] Add support for shot-wise output for IonQ jobs #3535

wants to merge 15 commits into from
+232 −4

Conversation

@radumarg
Copy link
Contributor

@radumarg radumarg commented Oct 21, 2025 •
edited
Loading

Summary: adds memory to support shotwise output

Details and comments:

  • need to get shotwise endpoint only when requested but default is to enable memory
  • do not attempt shotwise for ideal simulations

Fixes issue #3572.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 21, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@radumarg radumarg marked this pull request as ready for review October 29, 2025 17:21
@radumarg radumarg changed the title Partial implementation. Add support for shot-wise output in IonQ Oct 29, 2025
@radumarg
DCO Remediation Commit for Radu Marginean <[email protected]>
d687584 
I, Radu Marginean <[email protected]>, hereby add my Signed-off-by to this commit: 7e8774d
I, Radu Marginean <[email protected]>, hereby add my Signed-off-by to this commit: 671dd89

Signed-off-by: Radu Marginean <[email protected]>
@radumarg radumarg changed the title Add support for shot-wise output in IonQ Add support for shot-wise output fro IonQ jobs Oct 29, 2025
@radumarg radumarg changed the title Add support for shot-wise output fro IonQ jobs Add support for shot-wise output for IonQ jobs Oct 29, 2025
@radumarg radumarg mentioned this pull request Nov 4, 2025
Open
@sacpis
Copy link
Collaborator

sacpis commented Nov 12, 2025 •
edited by github-actions bot
Loading

/ok to test 5715afb

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Nov 12, 2025
@cuda-quantum-bot
Docs preview for PR #3535.
ab45af0
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@sacpis
formatting
c6fe0df 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Nov 12, 2025 •
edited by github-actions bot
Loading

/ok to test c6fe0df

Command Bot: Processing...

github-actions bot pushed a commit that referenced this pull request Nov 12, 2025
@cuda-quantum-bot
Docs preview for PR #3535.
38cf184
@github-actions
Copy link

github-actions bot commented Nov 12, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

bettinaheim
bettinaheim reviewed Nov 12, 2025
View reviewed changes
@sacpis
Copy link
Collaborator

sacpis commented Nov 19, 2025 •
edited by github-actions bot
Loading

/ok to test 86218fb

Command Bot: Processing...

@sacpis
format
ba6c288 
Signed-off-by: Sachin Pisal <[email protected]>
@sacpis
Copy link
Collaborator

sacpis commented Nov 19, 2025 •
edited by github-actions bot
Loading

/ok to test ba6c288

Command Bot: Processing...

@sacpis sacpis requested a review from bettinaheim November 19, 2025 21:18
@sacpis
Copy link
Collaborator

sacpis commented Nov 26, 2025 •
edited by github-actions bot
Loading

/ok to test 8976858

Command Bot: Processing...

@radumarg
Copy link
Contributor Author

radumarg commented Nov 26, 2025 •
edited
Loading

@bettinaheim Thank you for the code review. I implemented your suggestion for enabling 'memory' argument in C++ API interface. I also corrected an error in initial implementation, the bit-strings are now returned in big-endian format. Unless I am mistaken, Cuda-Q used the big-endian format for qubit ordering. For the moment merging this PR will be put on hold untill IonQ will finish some internal work which will allow us to test this change on QPU devices not only on IonQ simulator which we did for the moment.

@sacpis sacpis changed the title Add support for shot-wise output for IonQ jobs [DNM] Add support for shot-wise output for IonQ jobs Nov 26, 2025
github-actions bot pushed a commit that referenced this pull request Nov 26, 2025
@cuda-quantum-bot
Docs preview for PR #3535.
485dffb
@github-actions
Copy link

github-actions bot commented Nov 26, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radumarg @sacpis @bettinaheim